Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[snmp.service] Make swss.service a requisite for snmp.service #2790

Merged
merged 1 commit into from
Apr 17, 2019
Merged

[snmp.service] Make swss.service a requisite for snmp.service #2790

merged 1 commit into from
Apr 17, 2019

Conversation

stepanblyschak
Copy link
Collaborator

Trying to address #2750 by removing snmp.service required dependency on swss.service and adding it as requisite

Signed-off-by: Stepan Blyschak stepanb@mellanox.com

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[snmp.service] Make swss.service a requisite
b82b5b1 
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
@stepanblyschak stepanblyschak mentioned this pull request Apr 16, 2019
Closed
@qiluo-msft qiluo-msft merged commit 6a4ffef into sonic-net:master Apr 17, 2019
@stepanblyschak
Copy link
Collaborator Author

When swss.service failed, snmp.service fails and restart of swss.service does not start snmp.service when using Requisite.
However Requires has the same behaviour if swss and snmp failed to start.

@jleveque
Copy link
Contributor

@stepanblyschak: Can you clarify your last comment? Are you stating a problem here? A restart of swss.service should also restart snmp.service. This is the behavior we want, and it I believe this should happen with both Requires and Requisite. The behavior we don't want is for a call to start snmp.service to also attempt restarting swss.service if it is stopped -- Requires causes this to happen, whereas Requisite should not.

@stepanblyschak
Copy link
Collaborator Author

@jleveque
"A restart of swss.service should also restart snmp.service" - this works as expected
"don't want is for a call to start snmp.service to also attempt restarting swss.service if it is stopped" - this works as expected

If swss.service is stopped/inactive and snmp.service is stopped/inactive restart of swss.service does not start snmp.service. Is this desired?

@stepanblyschak
Copy link
Collaborator Author

@jleveque Similar behaviour as described for dhcp_relay here: #2752

@jleveque
Copy link
Contributor

I see. OK. Then this behavior should be fine. Once I add in the changes I describe in the issue you linked, the latter behavior should also work.

yxieca pushed a commit that referenced this pull request Apr 18, 2019
@stepanblyschak @yxieca
[snmp.service] Make swss.service a requisite (#2790)
08fed3c
MichelMoriniaux pushed a commit to criteo-forks/sonic-buildimage that referenced this pull request May 28, 2019
@stepanblyschak @MichelMoriniaux
[snmp.service] Make swss.service a requisite (sonic-net#2790)
a8c7ac2
@stepanblyschak stepanblyschak deleted the snmp_swss_requisite branch September 23, 2022 13:32
mssonicbld added a commit that referenced this pull request Oct 14, 2023
@mssonicbld
[submodule] Update submodule sonic-utilities to the latest HEAD autom…
0e964bf 
…atically (#16858)

#### Why I did it
src/sonic-utilities
```
* bf9c07c4 - (HEAD -> master, origin/master, origin/HEAD) Add target mode to sfputil firmware (#3002) (22 hours ago) [Anoop Kamath]
* 0e43e4dc - [sflow] Added egress Sflow support. (#2790) (2 days ago) [Rajkumar-Marvell]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

Assignees
No one assigned
Labels
Included in 201811 Branch Request for 201811 Branch :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stepanblyschak @jleveque @qiluo-msft @yxieca